Skip to content

Fix pytest warning about empty match parameter in pytest.raises #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Fix pytest warning about empty match parameter in pytest.raises #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab3420
Initial plan
Copilot Jul 24, 2025
2e30293
Fix pytest warning by removing empty match parameter from pytest.raises
Copilot Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@ def _assert_is_disconnected(client: BaseApiClient[StubT]) -> None:
"""Assert that the client is disconnected."""
assert not client.is_connected

with pytest.raises(ClientNotConnected, match=r"") as exc_info:
_ = client.channel
exc = exc_info.value
assert exc.server_url == _DEFAULT_SERVER_URL
assert exc.operation == "channel"
Comment on lines -31 to -35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the records this duplicated block looks like a wrong revert. At some point we had 2 blocks but one tested client.stub instead:

But then we removed the client.stub property as it needs to return a async version of the stub, which can only be done by the sub-class, but it looks like instead of being removed it duplicated the test for client.channel.


with pytest.raises(ClientNotConnected, match=r"") as exc_info:
with pytest.raises(ClientNotConnected) as exc_info:
_ = client.channel
exc = exc_info.value
assert exc.server_url == _DEFAULT_SERVER_URL
Expand Down
Loading