-
Notifications
You must be signed in to change notification settings - Fork 5
Add v1alpha8 variant of pagination structs #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
630f662 to
b3994c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we deprecate Params and remove PaginationParams too, right?
…onInfo` Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for v1alpha8 variants of pagination structs to provide backward compatibility while transitioning API versions. The changes deprecate existing pagination classes in favor of new unified implementations that support both v1 and v1alpha8 protobuf message formats.
- Introduces a new
PaginationInfoclass that can handle both v1 and v1alpha8 protobuf messages - Deprecates the existing
InfoandParamsclasses with appropriate migration guidance - Adds comprehensive test coverage for both v1 and v1alpha8 pagination functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/client/common/pagination/init.py | Adds new PaginationInfo class with dual proto support and deprecates legacy classes |
| tests/test_pagination.py | Comprehensive test suite covering both v1 and v1alpha8 pagination variants |
| RELEASE_NOTES.md | Documents deprecations and new v1alpha8 pagination features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.