Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Aug 18, 2025

  • Add v1alpha8 variant of pagination structs

Copilot AI review requested due to automatic review settings August 18, 2025 17:13
@Marenz Marenz requested a review from a team as a code owner August 18, 2025 17:13
@Marenz Marenz requested a review from shsms August 18, 2025 17:13
@github-actions github-actions bot added part:docs Affects the documentation part:microgrid Affects the microgrid protobuf definitions part:pagination Affects the pagination protobuf definitions labels Aug 18, 2025

This comment was marked as outdated.

@Marenz Marenz force-pushed the no-alpha8 branch 2 times, most recently from 630f662 to b3994c9 Compare August 19, 2025 08:27
@Marenz Marenz changed the title Integrate v1alpha8 into main namespace Add v1alpha8 variant of pagination structs Aug 19, 2025
@Marenz Marenz enabled auto-merge August 19, 2025 08:30
@llucax llucax added this to the v0.3.5 milestone Aug 19, 2025
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we deprecate Params and remove PaginationParams too, right?

@github-actions github-actions bot added the part:tests Affects the unit, integration and performance (benchmarks) tests label Aug 19, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for v1alpha8 variants of pagination structs to provide backward compatibility while transitioning API versions. The changes deprecate existing pagination classes in favor of new unified implementations that support both v1 and v1alpha8 protobuf message formats.

  • Introduces a new PaginationInfo class that can handle both v1 and v1alpha8 protobuf messages
  • Deprecates the existing Info and Params classes with appropriate migration guidance
  • Adds comprehensive test coverage for both v1 and v1alpha8 pagination functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/frequenz/client/common/pagination/init.py Adds new PaginationInfo class with dual proto support and deprecates legacy classes
tests/test_pagination.py Comprehensive test suite covering both v1 and v1alpha8 pagination variants
RELEASE_NOTES.md Documents deprecations and new v1alpha8 pagination features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Marenz Marenz added this pull request to the merge queue Aug 19, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 69b4682 Aug 19, 2025
5 checks passed
@Marenz Marenz deleted the no-alpha8 branch August 19, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:microgrid Affects the microgrid protobuf definitions part:pagination Affects the pagination protobuf definitions part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants