Apply changes from v0.3 to v1alpha8 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replacing and deprecating from_proto * using enum.Enum in favor of Enum * using enum.unique * addition of base id types * Signed-off-by: Mathias L. Baumann <[email protected]>
github-actions
bot
added
the
part:tests
Marenz
added
the
cmd:skip-release-notes
There was a problem hiding this comment.
Pull Request Overview
This PR applies changes from v0.3 to v1alpha8, introducing microgrid-related ID types and modernizing the enum implementation. The main focus is on adding new identifier classes and deprecating the existing enum conversion methods in favor of a more generic approach.
- Adds new ID classes for microgrid entities (EnterpriseId, MicrogridId, ElectricalComponentId, SensorId)
- Modernizes enum classes by adding
@enum.uniquedecorators and switching fromEnumtoenum.Enum - Deprecates existing
from_proto()methods in favor of a genericenum_from_proto()function
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/microgrid/test_ids_alpha8.py | Adds comprehensive tests for the new microgrid ID classes |
| src/frequenz/client/common/v1alpha8/microgrid/sensors.py | Introduces SensorId class for microgrid sensors |
| src/frequenz/client/common/v1alpha8/microgrid/electrical_components/init.py | Adds ElectricalComponentId and modernizes enum classes with deprecation warnings |
| src/frequenz/client/common/v1alpha8/microgrid/init.py | Adds EnterpriseId and MicrogridId classes for microgrid entities |
| src/frequenz/client/common/v1alpha8/metric/init.py | Modernizes Metric enum with deprecation warning |
Signed-off-by: Mathias L. Baumann <[email protected]>
|
I am merging this, as it is basically just already reviewed changes transported to a new path. |
|
Looks like my review is to late ⌛ |
Well, we can still fix anything you find :)- |
|
lgtm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the v0.3 changes done to the frequenz.client.common.* dir to frequenz.client.common.v1alpha8 dir