Skip to content

Fix base-client used wrongly #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix base-client used wrongly #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Frequenz Dispatch Client Library Release Notes

## New Features
## Bug Fixes

* Update BaseApiClient to get the http2 keepalive feature.
* Some Methods from the high-level API have been moved to this repo: The dispatch class now offers: `until`, `started`, `next_run` and `next_run_after`.
* Add `start_immediately` support to the `create` method. You can now specify "NOW" as the start time to trigger immediate dispatch. Note: While the dispatch CLI previously allowed this by converting "NOW" to a timestamp client-side before sending it to the server, this functionality is now supported directly on the server side!
* The client was broken due to wrong usage of the new BaseClient API.
9 changes: 5 additions & 4 deletions src/frequenz/client/dispatch/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,11 @@ def __init__(
self._setup_stub()

def _setup_stub(self) -> None:
self._stub = cast(
dispatch_pb2_grpc.MicrogridDispatchServiceAsyncStub,
dispatch_pb2_grpc.MicrogridDispatchServiceStub(self.channel),
)
stub = dispatch_pb2_grpc.MicrogridDispatchServiceStub(self.channel)
# We need the type: ignore here because the generated async stub only lives in
# the .pyi file (the interpreter doesn't know anything about it) so we can't use
# a proper `cast()`, we can only use the async stub as a type hint.
self._stub: dispatch_pb2_grpc.MicrogridDispatchServiceAsyncStub = stub # type: ignore

@property
def stub(self) -> dispatch_pb2_grpc.MicrogridDispatchServiceAsyncStub:
Expand Down
Loading