Add colors and formatting to dispatch-cli #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
Signed-off-by: Mathias L. Baumann <[email protected]>
llucax
approved these changes
Nov 28, 2024
| """Print the dispatch details in a nicely formatted way with colors.""" | ||
| # Determine the status and color | ||
| status: str = "running" if dispatch.started else "not running" | ||
| status_color: str = "green" if dispatch.started else "red" |
There was a problem hiding this comment.
Nitpick: What about gray for not started? Red looks like an error to me. Maybe we can sort of mimic systemctl status as many users may be familiar with them?
There was a problem hiding this comment.
My desire was that it stands out immediately what the status is :)
| val_color = "white" | ||
|
|
||
| if value in ("None", "False"): | ||
| val_color = "red" |
There was a problem hiding this comment.
Also here maybe gray for None?
| required=True, | ||
| ) | ||
| @click.option( | ||
| "--raw", |
There was a problem hiding this comment.
Possible future improvements:
- Split
--rawfrom--no-color - Set color on/off automatically based on
sys.stdin.isatty()
There was a problem hiding this comment.
Set color on/off automatically based on sys.stdin.isatty()
that actually seems to happen automatically, at least there is no color if I pipe it through cat or forward it into a file
There was a problem hiding this comment.
Ah cool. Extra point for click 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.