Skip to content

Add Dispatch.end_time and print it in dispatch-cli #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Add Dispatch.end_time and print it in dispatch-cli #142

merged 2 commits into from
Apr 15, 2025

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Apr 9, 2025

No description provided.

@Marenz Marenz requested review from a team as code owners April 9, 2025 11:38
@Marenz Marenz changed the title Add Dispatch.end_time and print in in dispatch-cli Add Dispatch.end_time and print it in dispatch-cli Apr 9, 2025
@Marenz Marenz enabled auto-merge April 9, 2025 11:39
@Marenz Marenz requested a review from llucax April 9, 2025 11:39
@github-actions github-actions bot added part:docs Affects the documentation part:cli Affects the command-line interface part:dispatcher labels Apr 9, 2025
llucax
llucax previously approved these changes Apr 14, 2025
View reviewed changes
@github-actions github-actions bot added the part:tests Affects the unit, integration and performance (benchmarks) tests label Apr 14, 2025
@Marenz Marenz requested a review from llucax April 14, 2025 15:58
llucax
llucax previously approved these changes Apr 15, 2025
View reviewed changes
@Marenz Marenz added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2025
llucax
llucax previously approved these changes Apr 15, 2025
View reviewed changes
@Marenz
Test: Make assert more verbose
d80afd6 
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz
Copy link
Contributor Author

Marenz commented Apr 15, 2025

Couldn't really track down that merge queue issue, but expanded the assert to be better readable for the next time

@Marenz Marenz enabled auto-merge April 15, 2025 09:32
@Marenz Marenz added this pull request to the merge queue Apr 15, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 6efd3d8 Apr 15, 2025
7 checks passed
@Marenz Marenz deleted the end_time branch April 15, 2025 09:53
@llucax
Copy link
Contributor

llucax commented Apr 15, 2025

What was it?

@Marenz
Copy link
Contributor Author

Marenz commented Apr 15, 2025

https://github.com/frequenz-floss/frequenz-client-dispatch-python/actions/runs/14463886957/job/40561663506

@llucax
Copy link
Contributor

llucax commented Apr 15, 2025

Thanks, that was a breeze to read 😒

@Marenz
Copy link
Contributor Author

Marenz commented Apr 15, 2025

Exactly my point. That's why I changed the assert ;)

@llucax
Copy link
Contributor

llucax commented Apr 15, 2025

OK, but that doesn't explain why the tests failed in the queue, it explains why you didn't know on the first failure 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llucax llucax llucax approved these changes

@stefan-brus-frequenz stefan-brus-frequenz Awaiting requested review from stefan-brus-frequenz stefan-brus-frequenz is a code owner automatically assigned from frequenz-floss/api-dispatch-team

@ela-kotulska-frequenz ela-kotulska-frequenz Awaiting requested review from ela-kotulska-frequenz ela-kotulska-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

No one assigned

Labels

part:cli Affects the command-line interface part:dispatcher part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marenz @llucax