-
Notifications
You must be signed in to change notification settings - Fork 4
Add Dispatch.end_time and print it in dispatch-cli
#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dispatch.end_time and print in in dispatch-cliDispatch.end_time and print it in dispatch-cli
llucax
previously approved these changes
Apr 14, 2025
Signed-off-by: Mathias L. Baumann <[email protected]>
llucax
previously approved these changes
Apr 15, 2025
llucax
previously approved these changes
Apr 15, 2025
Signed-off-by: Mathias L. Baumann <[email protected]>
|
Couldn't really track down that merge queue issue, but expanded the assert to be better readable for the next time |
llucax
approved these changes
Apr 15, 2025
|
What was it? |
|
Thanks, that was a breeze to read 😒 |
|
Exactly my point. That's why I changed the assert ;) |
|
OK, but that doesn't explain why the tests failed in the queue, it explains why you didn't know on the first failure 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
part:cli
Affects the command-line interface
part:dispatcher
part:docs
Affects the documentation
part:tests
Affects the unit, integration and performance (benchmarks) tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.