Skip to content

Update to use BaseId' ids #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

Update to use BaseId' ids #181

merged 2 commits into from
Jun 23, 2025

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Jun 12, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:cli Affects the command-line interface part:test-utils Affects the test utilities part:dispatcher labels Jun 12, 2025
@Marenz Marenz force-pushed the iddispatchididid branch from dac8dae to be03bbf Compare June 12, 2025 15:38
llucax
llucax reviewed Jun 13, 2025
View reviewed changes
@Marenz Marenz force-pushed the iddispatchididid branch from be03bbf to f6d760a Compare June 18, 2025 07:50
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Jun 18, 2025
@Marenz Marenz force-pushed the iddispatchididid branch 2 times, most recently from 01b207d to b7fff27 Compare June 18, 2025 08:26
@github-actions github-actions bot added the part:docs Affects the documentation label Jun 18, 2025
@Marenz Marenz marked this pull request as ready for review June 18, 2025 09:47
@Marenz Marenz requested review from a team as code owners June 18, 2025 09:47
llucax
llucax reviewed Jun 18, 2025
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the commit split is weird and I'm not sure if the new sleeps sneaked in accidentally or not.

I would keep all (and only) ID updates in one commit, and refactors in a different commit (the refactor commit is updating to use ID classes too).

@Marenz Marenz force-pushed the iddispatchididid branch 2 times, most recently from 9009f52 to 5a84236 Compare June 18, 2025 14:45
llucax
llucax reviewed Jun 18, 2025
View reviewed changes
@Marenz Marenz force-pushed the iddispatchididid branch from 5a84236 to 837dfc9 Compare June 19, 2025 13:18
@Marenz Marenz requested a review from llucax June 19, 2025 13:19
@Marenz
Add/use DispatchId and MicrogridId
5e87950 
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz force-pushed the iddispatchididid branch from 837dfc9 to 5e87950 Compare June 23, 2025 08:52
@Marenz Marenz enabled auto-merge June 23, 2025 08:53
@Marenz Marenz disabled auto-merge June 23, 2025 11:01
@Marenz Marenz merged commit ce985a7 into frequenz-floss:v0.x.x Jun 23, 2025
5 checks passed
@Marenz Marenz deleted the iddispatchididid branch June 23, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llucax llucax Awaiting requested review from llucax

Assignees

No one assigned

Labels

part:cli Affects the command-line interface part:dispatcher part:docs Affects the documentation part:test-utils Affects the test utilities part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marenz @llucax