Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Jul 16, 2025

  • Use correct form of logging
  • Reset release notes
  • Add Dispatch.started_at(now)

Marenz added 3 commits July 16, 2025 10:37
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
This way users can use a stable unchanging `now` across
calls and be sure that the result is always in respect to the same
`now`

Signed-off-by: Mathias L. Baumann <[email protected]>
Copilot AI review requested due to automatic review settings July 16, 2025 08:41
@Marenz Marenz requested review from a team as code owners July 16, 2025 08:41
@github-actions github-actions bot added part:docs Affects the documentation part:test-utils Affects the test utilities part:dispatcher labels Jul 16, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new deterministic-start check for Dispatch, standardizes logging in fake service tests, and resets release notes to templates.

  • Introduce Dispatch.started_at(now: datetime) and update started to delegate to it
  • Replace direct logging.debug calls with module-level _logger in fake service tests
  • Clear out RELEASE_NOTES.md content and insert placeholder comments

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/frequenz/client/dispatch/types.py Added started_at method and routed started through it
src/frequenz/client/dispatch/test/_service.py Defined _logger and updated debug calls in streaming tests
RELEASE_NOTES.md Reset notes and added placeholder comments for summary/upgrade
Comments suppressed due to low confidence (2)

src/frequenz/client/dispatch/types.py:432

  • No unit tests cover the new started_at method. Add tests for scenarios before start, during active period, after end, inactive dispatches, and recurring dispatches to ensure correct behavior.
    def started_at(self, now: datetime) -> bool:

RELEASE_NOTES.md:5

  • Release notes are left as placeholders. Please provide a concise summary of the changes and upgrade instructions before merging.
<!-- Here goes a general summary of what this release is about -->

@Marenz Marenz enabled auto-merge July 16, 2025 09:13
@Marenz Marenz added this pull request to the merge queue Jul 16, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 727f451 Jul 16, 2025
5 checks passed
@Marenz Marenz deleted the started_at branch July 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:dispatcher part:docs Affects the documentation part:test-utils Affects the test utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants