Fix: Use midnight UTC for date-only CLI timestamps instead of current time #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the behavior of date-only CLI timestamp inputs to use midnight UTC instead of preserving the current time. This ensures consistent and predictable behavior when users provide only a date without a specific time.
- Modified
FuzzyDateTimeto detect date-only inputs and set them to midnight UTC - Added comprehensive test coverage for both date-only and date-time inputs
- Updated release notes to document the new behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/client/dispatch/_cli_types.py | Added logic to detect date-only parsing and set time to midnight UTC |
| tests/test_cli.py | Added test cases to verify date-only inputs are set to midnight |
| RELEASE_NOTES.md | Documented the new feature in release notes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Marenz
force-pushed
the
better-cli-timestamps
branch
from
1656fcb to
4269fc4
Compare
… time Date-only inputs now default to midnight UTC instead of using current time Signed-off-by: Mathias L. Baumann <[email protected]>
Marenz
force-pushed
the
better-cli-timestamps
branch
from
4269fc4 to
6bb7e1c
Compare
llucax
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date-only inputs now default to midnight UTC instead of using current time
Fixes #198