Add support for duration=None #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
Signed-off-by: Mathias L. Baumann <[email protected]>
|
updated |
daniel-zullo-frequenz
previously approved these changes
Sep 9, 2024
llucax
reviewed
Sep 10, 2024
Comment on lines
+28
to
+29
| # pylint: enable=no-name-in-module | ||
|
|
There was a problem hiding this comment.
This doesn't look right here, but you could also just disable it globally in the whole project as mypy will check for this anyway.
There was a problem hiding this comment.
I think this is mostly at this place due to black
There was a problem hiding this comment.
Yeah, it is weird, it has to be just before the next line.
| duration: timedelta | None | ||
| """The duration of the dispatch, represented as a timedelta. | ||
| If None, the dispatch is considered to be "infinite" or "no-duration". |
There was a problem hiding this comment.
For me "no-duration" is not super clear, I think I would say "instantaneous" (or maybe both), or use an example as you did in the docs above.
Create and other places already use round(), so this makes it more consistent. Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
daniel-zullo-frequenz
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.