Implement stream() for FakeService #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marenz
commented
Sep 19, 2024
Marenz
commented
- TestService: Minor refactor of imports
- Add support in FakeService for stream()
Signed-off-by: Mathias L. Baumann <[email protected]>
github-actions
bot
added
part:docs
Marenz
force-pushed
the
streamstream
branch
2 times, most recently
from
039d62e to
23ff599
Compare
llucax
reviewed
Sep 24, 2024
| self._last_id = 0 | ||
| self._stream_channel = Broadcast(name="dispatch-stream") | ||
| self._stream_sender = self._stream_channel.new_sender() | ||
| self.dispatches = {} |
There was a problem hiding this comment.
If you have this, it makes no sense to have the default_factory in dispatches: dict[int, list[Dispatch]] = dataclasses.field(default_factory=dict).
I would add a default_factory for the channel too instead of implementing __init__() though.
Marenz
force-pushed
the
streamstream
branch
from
23ff599 to
1ebd6b8
Compare
llucax
reviewed
Sep 25, 2024
|
|
||
| def __post_init__(self) -> None: | ||
| """Initialize the stream sender.""" | ||
| self._stream_sender = self._stream_channel.new_sender() |
There was a problem hiding this comment.
To be honest I don't see a point on having FakeService be a dataclass at this point, it is causing more harm than good. You have one public property and 3 property hacks. Why not making it a regular class with a regular __init__()?
Also adds a test for it. Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Marenz
force-pushed
the
streamstream
branch
from
1ebd6b8 to
eb7e8bc
Compare
|
Updated accordingly |
llucax
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.