Client.stream: Raise exception on connection loss #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
Signed-off-by: Mathias L. Baumann <[email protected]>
Marenz
force-pushed
the
streamstream
branch
from
ba15b6e to
d5dbc25
Compare
Marenz
changed the title
llucax
approved these changes
Sep 26, 2024
Comment on lines
+212
to
+213
| # pylint: disable=protected-access | ||
| if broadcaster is not None and broadcaster._channel.is_closed: |
There was a problem hiding this comment.
This is not nice. We should add a broadcaster.is_running() or something. I think there is no one day that goes by without me thinking "we need to implement this using core.asyncio.Service". 😬
After I finish with the microgrid API client... 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.