Skip to content

Include init files in sybil #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

Include init files in sybil #96

merged 1 commit into from
Oct 2, 2024

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Oct 2, 2024

No description provided.

@Marenz
Include init files in sybil
ae978c3 
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz requested review from a team as code owners October 2, 2024 10:09
@Marenz Marenz requested review from ktickner and shsms October 2, 2024 10:09
@Marenz Marenz mentioned this pull request Oct 2, 2024
Closed
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:dispatcher labels Oct 2, 2024
@llucax
Copy link
Contributor

llucax commented Oct 2, 2024

This repo doesn't have any examples in the __init__.py files though. Not sure if the issue happened also in this case.

llucax
llucax approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would be interesting to try this in a repo that has examples in the __init__.py files.

@Marenz Marenz added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Oct 2, 2024
@Marenz Marenz enabled auto-merge October 2, 2024 12:23
@Marenz Marenz added this pull request to the merge queue Oct 2, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit c1373e2 Oct 2, 2024
14 of 15 checks passed
@Marenz Marenz deleted the include-init branch October 2, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llucax llucax llucax approved these changes

@ktickner ktickner Awaiting requested review from ktickner ktickner is a code owner automatically assigned from frequenz-floss/api-dispatch-team

@shsms shsms Awaiting requested review from shsms shsms is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

No one assigned

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:dispatcher part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marenz @llucax