Skip to content

Add YEARLY frequency #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

Add YEARLY frequency #97

merged 2 commits into from
Oct 17, 2024

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Oct 17, 2024

No description provided.

@Marenz
Add YEARLY frequency
3074b6b 
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz requested review from a team as code owners October 17, 2024 14:51
@github-actions github-actions bot added part:docs Affects the documentation part:dispatcher labels Oct 17, 2024
@Marenz Marenz enabled auto-merge October 17, 2024 14:51
shsms
shsms previously approved these changes Oct 17, 2024
View reviewed changes
@Marenz Marenz added this pull request to the merge queue Oct 17, 2024
@Marenz
Copy link
Contributor Author

Marenz commented Oct 17, 2024

WTF is with the ci, I didn't touch this

src/frequenz/client/dispatch/_client.py:165: error: Argument "page_size" to "PaginationParams" has incompatible type "int | None"; expected "int" [arg-type]

@Marenz
Fix page_size=None case
fdb6bde 
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz removed this pull request from the merge queue due to a manual request Oct 17, 2024
@Marenz Marenz added this pull request to the merge queue Oct 17, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit cf54baa Oct 17, 2024
14 checks passed
@Marenz Marenz deleted the add_yearly branch October 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shsms shsms shsms approved these changes

@stefan-brus-frequenz stefan-brus-frequenz Awaiting requested review from stefan-brus-frequenz stefan-brus-frequenz is a code owner automatically assigned from frequenz-floss/api-dispatch-team

@ela-kotulska-frequenz ela-kotulska-frequenz Awaiting requested review from ela-kotulska-frequenz ela-kotulska-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

No one assigned

Labels

part:dispatcher part:docs Affects the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marenz @shsms