Unify public trades streaming and listing #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
cwasicki
reviewed
Mar 18, 2025
cwasicki
reviewed
Mar 19, 2025
|
Superseded by #113 |
- Bumped `frequenz-api-electricity-trading` to `>=0.5.0` Signed-off-by: camille-bouvy-frequenz <[email protected]>
- Removed `list_public_trades` - Replaced `public_trades_stream` with `receive_public_trades` - Updated the method to support streaming with optional time range (`start_time`, `end_time`) - Update the unit tests with the new function name Signed-off-by: camille-bouvy-frequenz <[email protected]>
Signed-off-by: camille-bouvy-frequenz <[email protected]>
camille-bouvy-frequenz
force-pushed
the
refactor-pt-stream
branch
from
64911b8 to
907d8be
Compare
Signed-off-by: cwasicki <[email protected]>
camille-bouvy-frequenz
force-pushed
the
refactor-pt-stream
branch
from
907d8be to
8606955
Compare
cwasicki
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the client functions to align with the gRPC changes in
frequenz-api-electricity-tradingv0.5.0(see here).The main changes are:
list_public_tradespublic_trades_streamwithreceive_public_tradesstart_time,end_time)frequenz-api-electricity-tradingto v0.5.0protobufto avoid dependency conflicts.