Skip to content

Unify public trades streaming and listing #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Unify public trades streaming and listing #113

wants to merge 5 commits into from

Conversation

@cwasicki
Copy link
Collaborator

@cwasicki cwasicki commented Mar 19, 2025

Replacing #112:

  • Removed list_public_trades
  • Replaced public_trades_stream with receive_public_trades
  • Updated the method to support streaming with optional time range (start_time, end_time)
  • Updated the unit tests with the new function name
  • Updated the dependencies:
  • requenz-api-electricity-trading to v0.5.0
  • protobuf to avoid dependency conflicts.

camille-bouvy-frequenz and others added 5 commits March 13, 2025 17:04
@camille-bouvy-frequenz
Upgrade dependencies for updated gRPC streaming API
e534476 
- Bumped `frequenz-api-electricity-trading` to `>=0.5.0`
- Updated `protobuf` to `>=5.29.2`

Signed-off-by: camille-bouvy-frequenz <[email protected]>
@camille-bouvy-frequenz
Unify Public Trades streaming and listing
e33bd3f 
- Removed `list_public_trades`
- Replaced `public_trades_stream` with `receive_public_trades`
- Updated the method to support streaming with optional time range (`start_time`, `end_time`)
- Update the unit tests with the new function name

Signed-off-by: camille-bouvy-frequenz <[email protected]>
@camille-bouvy-frequenz
Update release notes
64911b8 
Signed-off-by: camille-bouvy-frequenz <[email protected]>
@cwasicki
Fix receive_public_trades method
8a75e9e 
The delivery period does not need to be in the past. Moreover the
protobuf dependency is tightened again.
@cwasicki
Switch CLI tool to use public trade streams
4cd0051
@cwasicki cwasicki requested a review from a team as a code owner March 19, 2025 16:28
@cwasicki cwasicki requested review from shsms and removed request for a team March 19, 2025 16:28
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Mar 19, 2025
@cwasicki cwasicki mentioned this pull request Mar 19, 2025
Merged
@cwasicki cwasicki deleted the stream branch March 27, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shsms shsms Awaiting requested review from shsms

Assignees

No one assigned

Labels

part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cwasicki @camille-bouvy-frequenz