Skip to content

Conversation

@llucax
Copy link
Contributor

@llucax llucax commented Nov 18, 2024

We now use the new suggested way to get the stub, so it has proper async type hints.

We also enable the old behavior to retry on stream exhaustion because we don't expect data streaming to end normally, so we want to keep retrying if that happens.

@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:client Affects the client code labels Nov 18, 2024
@github-actions github-actions bot added the part:docs Affects the documentation label Nov 18, 2024
@llucax
Copy link
Contributor Author

llucax commented Nov 18, 2024

Draft because it needs a release of v0.8.0 (and an update of the dependency in pyproject.toml).

@llucax llucax self-assigned this Nov 18, 2024
@llucax llucax added this to the v0.6.0 milestone Nov 18, 2024
@llucax llucax requested review from Marenz and shsms November 18, 2024 15:32
@Marenz
Copy link
Contributor

Marenz commented Nov 18, 2024

fyi, PR in base-client was merged, I updated URL in pyproject file

We now use the new suggested way to get the `stub`, so it has proper
async type hints.

We also enable the old behavior to retry on stream exhaustion because we don't expect data streaming to end normally, so we want to keep retrying if that happens.

Signed-off-by: Leandro Lucarella <[email protected]>
@Marenz Marenz marked this pull request as ready for review November 19, 2024 09:12
@Marenz Marenz requested review from a team as code owners November 19, 2024 09:12
@Marenz Marenz requested a review from thea-leake November 19, 2024 09:12
Marenz
Marenz previously approved these changes Nov 19, 2024
This is the default, and we are getting a linter warning about it in the
CI which is noisy and not useful.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Copy link
Contributor Author

llucax commented Nov 19, 2024

I'm sneaking in a commit to stop getting those annoying warnings about --platform from docker.

@llucax llucax enabled auto-merge November 19, 2024 11:48
@llucax llucax disabled auto-merge November 19, 2024 12:04
@llucax llucax merged commit a8124b2 into frequenz-floss:v0.x.x Nov 19, 2024
14 checks passed
@llucax llucax deleted the base-client-0.8 branch November 19, 2024 12:04
github-merge-queue bot pushed a commit to frequenz-floss/frequenz-dispatch-python that referenced this pull request Nov 19, 2024
Marenz added a commit to frequenz-floss/frequenz-dispatch-python that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:client Affects the client code part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants