-
Notifications
You must be signed in to change notification settings - Fork 5
Update the client-base dependency to v0.8.0
#100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f08d26f to
b720f16
Compare
b720f16 to
ea61581
Compare
|
Draft because it needs a release of v0.8.0 (and an update of the dependency in |
ea61581 to
00cbcae
Compare
|
fyi, PR in base-client was merged, I updated URL in pyproject file |
We now use the new suggested way to get the `stub`, so it has proper async type hints. We also enable the old behavior to retry on stream exhaustion because we don't expect data streaming to end normally, so we want to keep retrying if that happens. Signed-off-by: Leandro Lucarella <[email protected]>
00cbcae to
39569c4
Compare
Marenz
previously approved these changes
Nov 19, 2024
This is the default, and we are getting a linter warning about it in the CI which is noisy and not useful. Signed-off-by: Leandro Lucarella <[email protected]>
|
I'm sneaking in a commit to stop getting those annoying warnings about |
github-merge-queue bot
pushed a commit
to frequenz-floss/frequenz-dispatch-python
that referenced
this pull request
Nov 19, 2024
- **Update to latest channels & dispatch client** Blocked by: * frequenz-floss/frequenz-sdk-python#1109 * frequenz-floss/frequenz-client-dispatch-python#109 * frequenz-floss/frequenz-client-microgrid-python#100
Marenz
added a commit
to frequenz-floss/frequenz-dispatch-python
that referenced
this pull request
Nov 19, 2024
- **Update to latest channels & dispatch client** Blocked by: * frequenz-floss/frequenz-sdk-python#1109 * frequenz-floss/frequenz-client-dispatch-python#109 * frequenz-floss/frequenz-client-microgrid-python#100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
part:client
Affects the client code
part:docs
Affects the documentation
part:tests
Affects the unit, integration and performance (benchmarks) tests
part:tooling
Affects the development tooling (CI, deployment, dependency management, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use the new suggested way to get the
stub, so it has proper async type hints.We also enable the old behavior to retry on stream exhaustion because we don't expect data streaming to end normally, so we want to keep retrying if that happens.