Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented May 28, 2025

In anticipation of the upcoming release of the base-client

@Copilot Copilot AI review requested due to automatic review settings May 28, 2025 08:36
@Marenz Marenz requested review from a team as code owners May 28, 2025 08:36
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label May 28, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the allowed version range for frequenz-client-base to include the upcoming 0.11.0 release.

  • Bumps the upper bound of frequenz-client-base from <0.10.0 to <0.12.0 in pyproject.toml.
Comments suppressed due to low confidence (1)

pyproject.toml:41

  • [nitpick] Consider adding or updating tests to verify compatibility with frequenz-client-base 0.11.x.
"frequenz-client-base >= 0.8.0, < 0.12.0",

"frequenz-api-microgrid >= 0.15.3, < 0.16.0",
"frequenz-channels >= 1.0.0-rc1, < 2.0.0",
"frequenz-client-base >= 0.8.0, < 0.10.0",
"frequenz-client-base >= 0.8.0, < 0.12.0",
Copy link

Copilot AI May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Add a CHANGELOG or relevant documentation entry to note support for frequenz-client-base 0.11.0.

Copilot uses AI. Check for mistakes.
@Marenz Marenz enabled auto-merge May 28, 2025 09:56
Copy link

@hannah-stevenson-frequenz hannah-stevenson-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FWIW NTIKA

@Marenz Marenz added this pull request to the merge queue May 28, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 6e01ff3 May 28, 2025
5 checks passed
@Marenz Marenz deleted the base-client branch May 28, 2025 10:08
@llucax
Copy link
Contributor

llucax commented May 28, 2025

Did you actually tried to use it with the current client-base HEAD, because there are some breaking changes that could affect this client, I'm not sure if blindly bumping the dependency is enough to allow for unreleased, untested code 😬

@Marenz
Copy link
Contributor Author

Marenz commented May 28, 2025

I will find out very soon 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants