-
Notifications
You must be signed in to change notification settings - Fork 5
Update base-client min version to v0.11 #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the minimum version of frequenz-client-base to v0.11, adds test assertions for new streaming event types, and documents the change in the release notes.
- Bumped
frequenz-client-baseversion constraint inpyproject.toml. - Extended
tests/test_client.pyto assertStreamStartedandStreamRetryingevents. - Updated
RELEASE_NOTES.mdto mention new streaming notification types.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_client.py | Add imports and repeated assertions for new stream event types. |
| pyproject.toml | Bump frequenz-client-base dependency to >=0.11.0, <0.12.0. |
| RELEASE_NOTES.md | Document handling of StreamStarted, StreamRetrying, and StreamFatalError. |
Comments suppressed due to low confidence (1)
tests/test_client.py:1069
- The tests cover retry logic but don’t include a
StreamFatalErrorscenario. Consider adding a test case that triggers and assertsStreamFatalErrorto match the release notes.
assert isinstance(await receiver.receive(), StreamStarted)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, wait! You need to also update all the type hints for the client streaming methods, they are only returning XxxData now, but they should return also StreamingEvents or whatever it was called.
321c0c4 to
79ef470
Compare
|
Updated. CI will fail until we release base-client v0.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing all the component-specific methods using _new_component_data_receiver(), like meter_data(), inverter_data(), etc.
|
It's a bit inconsistent that there is one method |
The |
cb98fa1 to
98ec5c8
Compare
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
|
I'm changing this to a draft until we decide what we do with the new events, if we really want to mix them with real data. |
|
I'm thinking that another alternative if we want to move forward more quickly (in case this is blocking something), we could just filter the events here in the client for now, and keep sending only data via the streams. So basically we contain the breaking change in the |
|
But this will quickly spread though other clients, so we need to find a sustainable solution for the |
No description provided.