Skip to content

Inherit from BaseApiClient #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2024
Merged

Inherit from BaseApiClient #88

merged 5 commits into from
Sep 3, 2024

Conversation

@llucax
Copy link
Contributor

@llucax llucax commented Sep 3, 2024

  • Rename ApiClient to MicrogridApiClient
  • Rename the api attribute to stub
  • Make MicrogridApiClient inherit from BaseApiClient
  • Add a connect parameter to the MicrogridApiClient constructor
  • Rename channel_options to channels_defaults

@llucax
Rename ApiClient to MicrogridApiClient
cef635f 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Rename the api attribute to stub
57e954c 
This is to match the `BaseApiClient` class, from which we'll inherit
soon.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Make MicrogridApiClient inherit from BaseApiClient
daec574 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Add a connect parameter to the MicrogridApiClient constructor
04bf4fc 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Rename channel_options to channels_defaults
91fd3f0 
The parameter `channel_options` in the constructor of
`MicrogridApiClient` was renamed to `channels_defaults` to match the
name used in `BaseApiClient`.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax requested review from a team as code owners September 3, 2024 11:58
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:client Affects the client code labels Sep 3, 2024
@llucax llucax self-assigned this Sep 3, 2024
@llucax llucax added this to the v0.6.0 milestone Sep 3, 2024
@llucax llucax added scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users labels Sep 3, 2024
@llucax llucax enabled auto-merge September 3, 2024 11:58
@llucax llucax added this pull request to the merge queue Sep 3, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 0d8bd4c Sep 3, 2024
@llucax llucax deleted the base-client branch September 3, 2024 13:05
@llucax llucax mentioned this pull request Nov 19, 2024
Closed
@llucax llucax linked an issue Nov 19, 2024 that may be closed by this pull request
Use the new BaseApiClient base class #79
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shsms shsms shsms approved these changes

@tiyash-basu-frequenz tiyash-basu-frequenz Awaiting requested review from tiyash-basu-frequenz tiyash-basu-frequenz is a code owner automatically assigned from frequenz-floss/api-microgrid-team

Assignees

@llucax llucax

Labels

part:client Affects the client code part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users

Projects

None yet

Milestone

v0.6.0

Development

Successfully merging this pull request may close these issues.

Use the new BaseApiClient base class

2 participants

@llucax @shsms