Use call_stub_method() to call stub methods
#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use the `MicrogridAsyncStub` type for the async stub internally, so we don't need to cast sync stuff to async anymore. Signed-off-by: Leandro Lucarella <[email protected]>
This utility function from `frequenz-client-base` simplifies the implementation of the client methods that call the gRPC stub methods, automatically converting the gRPC errors to `ApiClientError` exceptions. Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
part:tests
llucax
added
the
cmd:skip-release-notes
tiyash-basu-frequenz
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utility function from
frequenz-client-basesimplifies the implementation of the client methods that call the gRPC stub methods, automatically converting the gRPC errors toApiClientErrorexceptions.We also now use the
MicrogridAsyncStubtype for the async stub internally, so we don't need to cast sync stuff to async anymore.