Upgrade to reporting API v0.5 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
cwasicki
reviewed
Nov 27, 2024
pyproject.toml
Outdated
| "typing_extensions >= 4.6.1, < 5", | ||
| "grpc-stubs == 1.53.0.5", | ||
| "frequenz-api-reporting >= 0.2.0, < 0.5", | ||
| "frequenz-api-reporting >= 0.2.0, < 0.6", |
There was a problem hiding this comment.
The lower version needs to be updated where MetricConnections was introduced, otherwise this fails.
| "warning": state.warnings, | ||
| "error": state.errors, | ||
| }.items(): | ||
| # Skip if the category is not present |
There was a problem hiding this comment.
Why are these comments removed?
cwasicki
reviewed
Nov 27, 2024
RELEASE_NOTES.md
Outdated
| ## Upgrading | ||
|
|
||
| <!-- Here goes notes on how to upgrade from previous versions, including deprecations and what they should be replaced with --> | ||
| * Update to use frequenz-api-reporting 0.6 |
There was a problem hiding this comment.
This needs more explanation because this has a dependency with the service.
flora-hofmann-frequenz
force-pushed
the
update_api_requirement
branch
4 times, most recently
from
2d7480f to
b154b7b
Compare
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
update_api_requirement
branch
from
b154b7b to
9e66c57
Compare
cwasicki
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes
MetricConnectionsin the request message, that comes with a breaking change in the API specs. To ensure compatibility, both the client and service must be updated simultaneously. Specifically: