Update repo-config and setuptools #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
cwasicki
reviewed
Nov 28, 2024
pyproject.toml
Outdated
| "setuptools_scm[toml] == 7.1.0", | ||
| "setuptools == 75.5.0", | ||
| "setuptools_scm[toml] == 8.1.0", | ||
| "frequenz-repo-config[lib] == 0.10.0", |
There was a problem hiding this comment.
Doesn't this need updating?
There was a problem hiding this comment.
It is updating according to the repo config specs. 75.5.0 and 8.1.0 are the versions required.
There was a problem hiding this comment.
I mean why is repo config not updated here?
There was a problem hiding this comment.
Sorry, I thought you meant the setup tools update... Will check!
flora-hofmann-frequenz
force-pushed
the
update_repo
branch
from
a8991d6 to
81612be
Compare
I've ran the migration script. Could you please review again? |
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
update_repo
branch
from
81612be to
f622658
Compare
cwasicki
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.