Skip to content

Conversation

@cwasicki
Copy link
Contributor

@cwasicki cwasicki commented Jan 3, 2025

This adds support for the API endpoint to query aggregated data based on user-defined formulae. Latter can be passed by the user as strings (e.g. #CID1 + #CID2) as documented in the API specs.

Fixes #24

@github-actions github-actions bot added the part:docs Affects the documentation label Jan 3, 2025
Copy link
Collaborator

@flora-hofmann-frequenz flora-hofmann-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs rebasing. It shouldn't include the readme changes.

@cwasicki
Copy link
Contributor Author

cwasicki commented Jan 3, 2025

Yes, it requires rebasing once #130 is in

Copy link
Collaborator

@flora-hofmann-frequenz flora-hofmann-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwasicki cwasicki dismissed flora-hofmann-frequenz’s stale review January 3, 2025 15:03

The merge-base changed after approval.

@cwasicki cwasicki enabled auto-merge January 3, 2025 15:09
@cwasicki
Copy link
Contributor Author

cwasicki commented Jan 3, 2025

Rebased.

@cwasicki cwasicki disabled auto-merge January 3, 2025 15:10
@cwasicki cwasicki enabled auto-merge January 3, 2025 15:10
@flora-hofmann-frequenz
Copy link
Collaborator

Looks like something still needs to be signed?

This adds support for the API endpoint to query aggregated data based on
user-defined formulae. Latter can be passed by the user as strings
(e.g. `#CID1 + #CID2`) as documented in the API specs.

Signed-off-by: cwasicki <[email protected]>
Signed-off-by: cwasicki <[email protected]>
@cwasicki cwasicki added this pull request to the merge queue Jan 3, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit a490e8b Jan 3, 2025
14 checks passed
@cwasicki cwasicki deleted the formula branch January 3, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support user-defined metric formulas

2 participants