Skip to content

Ensure timezone-aware timestamps in formula endpoint result #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Ensure timezone-aware timestamps in formula endpoint result #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
## Upgrading

* The CLI tool is moved to dedicated folder.
* Timestamps of aggregated (formula) requests are now timezone-aware.

<!-- Here goes notes on how to upgrade from previous versions, including deprecations and what they should be replaced with -->

Expand Down
4 changes: 3 additions & 1 deletion src/frequenz/client/reporting/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ class AggregatedMetric:
def sample(self) -> MetricSample:
"""Return the aggregated metric sample."""
return MetricSample(
timestamp=self._data_pb.sample.sampled_at.ToDatetime(),
timestamp=self._data_pb.sample.sampled_at.ToDatetime().replace(
tzinfo=timezone.utc
),
microgrid_id=self._data_pb.aggregation_config.microgrid_id,
component_id=self._data_pb.aggregation_config.aggregation_formula,
metric=self._data_pb.aggregation_config.metric,
Expand Down
Loading