Update client to use FilterOptions #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:tooling
flora-hofmann-frequenz
force-pushed
the
update_includeoptions
branch
from
18372ad to
52c27ab
Compare
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
update_includeoptions
branch
from
52c27ab to
9130f36
Compare
cwasicki
reviewed
Mar 11, 2025
| else PBFilterOption.FILTER_OPTION_EXCLUDE | ||
| ) | ||
| include_options = PBIncludeOptions( | ||
| include_options = PBReceiveMicrogridComponentsDataStreamRequest.IncludeOptions( |
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
Because the frequenz-api v0.7.0 has changed so that IncludeOptions is now inside ReceiveMicrogridComponentsDataStreamRequest: frequenz-floss/frequenz-api-reporting@v0.6.0...v0.7.0#diff-1f163e5662a0ad82784b3f2f391169e19f5f89baa3d9f681b934d33d7a6f8a67R246
cwasicki
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the reporting-api update #147 and changes the client accordingly.