Add sensor request to readme #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README by bumping the installation version and adding new code examples demonstrating how to query sensor data.
- Updated installation instructions to use version 0.16.0.
- Added examples for querying metrics for a single microgrid sensor and for multiple microgrids and sensors.
- Updated the command-line tool description to reflect the new functionality.
Comments suppressed due to low confidence (1)
README.md:77
- Consider adding import statements (e.g., for datetime, timedelta, and Metric) at the beginning of the code snippet to clarify dependencies for users copying the example.
sample async for sample in
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
add_sensor_example
branch
from
b377f2a to
a267e23
Compare
cwasicki
reviewed
May 6, 2025
| microgrid_id=1, | ||
| sensor_id=100, | ||
| metrics=[Metric.SENSOR_IRRADIANCE], | ||
| start_dt=datetime.fromisoformat("2024-05-01T00:00:00"), |
There was a problem hiding this comment.
We should first change these argument names to {start,end}_time before sending this out.
There was a problem hiding this comment.
This would be with the next release tough. Should I just change it for sensors & in this PR and then make a new release?
There was a problem hiding this comment.
Good point, let's get this in, then change the arguments and make a new release with this and the receiver changes soon.
There was a problem hiding this comment.
Addressed in #178
cwasicki
approved these changes
May 6, 2025
Merged
flora-hofmann-frequenz
added a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.