Update components retrival functions #177
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements naming changes for component data retrieval functions as requested in #169, shifting from “list_…” functions to “receive_…” functions and updating the receiver handling.
- Renames functions in the Reporting API client and CLI to reflect the new naming convention.
- Updates the RELEASE_NOTES.md to document the renaming changes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/client/reporting/cli/main.py | Updates function call from list to receive (with a misspelling noted) |
| src/frequenz/client/reporting/_client.py | Renames several functions and methods for component data retrieval (inconsistently spelled) |
| RELEASE_NOTES.md | Documents renaming from list to receive in component data retrieval functions |
flora-hofmann-frequenz
force-pushed
the
change_components
branch
3 times, most recently
from
90a60e4 to
c593f14
Compare
| include_bounds: Whether to include the bound data. | ||
| Yields: | ||
| Returns: |
There was a problem hiding this comment.
You might want to change the return type a receiver as well.
| receiver = broadcaster.new_receiver() | ||
| async for data in receiver: | ||
| yield data | ||
| return broadcaster.new_receiver() |
There was a problem hiding this comment.
This appears to be creating a new GrpcStreamBroadcaster everytime a new receiver is requested. But that would create a new connection to the API service each time. Instead you should hold on to the broadcaster instance and reuse it, like here:
- https://github.com/frequenz-floss/frequenz-client-electricity-trading-python/blob/a029d214ea7cdaf7f84ed72c7990546705e7a558/src/frequenz/client/electricity_trading/_client.py#L210-L215
- https://github.com/frequenz-floss/frequenz-client-electricity-trading-python/blob/a029d214ea7cdaf7f84ed72c7990546705e7a558/src/frequenz/client/electricity_trading/_client.py#L299-L322
flora-hofmann-frequenz
force-pushed
the
change_components
branch
from
c593f14 to
738c7a4
Compare
|
Hi Flora, just realized why this was complicated. Christoph and I had solved this some time back. I've made a PR with it into your branch: flora-hofmann-frequenz#1 |
flora-hofmann-frequenz
force-pushed
the
change_components
branch
from
738c7a4 to
b888a59
Compare
github-actions
bot
added
the
part:tests
flora-hofmann-frequenz
force-pushed
the
change_components
branch
from
b888a59 to
b70675a
Compare
Signed-off-by: Flora <[email protected]>
Signed-off-by: Flora <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
|
@flora-hofmann-frequenz I pushed to your branch directly because I was too lazy to create a new PR. @cwasicki fyi |
| include_bounds: Whether to include the bound data. | ||
| Yields: | ||
| Returns: |
There was a problem hiding this comment.
Returns:
A receiver of MetricSamples?
| include_bounds: Whether to include the bound data. | ||
| Yields: | ||
| Returns: |
|
I just realized we need to do the same |
This turns a `Receiver[ComponentDataBatch]` into a `Receiver[MetricSample]` by unrolling `ComponentDataBatch` objects into multiple `MetricSample`s. Then this receiver is used in the client to return `Receiver`s instead of iterators for component data streams. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
|
Also did for the AggregatedDataStream, and some more simplification and cleanup. |
Think we forgot to take out 'async' when refactoring in #177
3 participants
Implemented comments from #169 for components.