Update proto warnings #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull Request Overview
This PR updates the configuration for warning handling related to protobuf and adjusts dependency versions.
- Removes specific version pinning for grpcio and protobuf.
- Simplifies pytest warning options by replacing verbose -W flags with a filterwarnings section.
- Updates the release notes to mention the protobuf warning display update.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Removes grpcio/protobuf constraints and revises warning options for pytest. |
| RELEASE_NOTES.md | Updates the release note to mention protobuf warnings changes. |
Comments suppressed due to low confidence (2)
pyproject.toml:156
- Review the change from detailed warning flags to a simpler '-vv' option to ensure that all necessary warnings are still being managed appropriately. Confirm that the new filterwarnings entries fully cover the required warning behavior.
+addopts = "-vv"
pyproject.toml:157
- Consider verifying that the bare 'error' entry in the filterwarnings list produces the intended behavior, as it is very general and might affect other warnings unexpectedly.
+filterwarnings = [
flora-hofmann-frequenz
force-pushed
the
proto_warnings
branch
2 times, most recently
from
63958b4 to
6c5f77e
Compare
llucax
reviewed
Jun 5, 2025
RELEASE_NOTES.md
Outdated
| ## Bug Fixes | ||
|
|
||
| <!-- Here goes notable bug fixes that are worth a special mention or explanation --> | ||
| * Updated display of protobuf version warnings |
There was a problem hiding this comment.
This really shouldn't go to the release notes, it is internal (testing), so it doesn't affect the users of this library.
Comment on lines
33
to
34
| "grpcio >=1.70.0, < 2", | ||
| "protobuf >= 5.29.3, < 7", |
There was a problem hiding this comment.
This should probably be separated in a different commit or at least be clarified in the commit message.
But you should probably not remove the protobuf dependency, as you are using it in your code.
flora-hofmann-frequenz
force-pushed
the
proto_warnings
branch
2 times, most recently
from
dc215c6 to
4377afd
Compare
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
proto_warnings
branch
from
4377afd to
0c7a7fc
Compare
flora-hofmann-frequenz
requested review from
llucax
and removed request for
cwasicki
llucax
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.