Renaming to allow for api-reporting update #205
Merged
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the client’s reporting layer to match an upstream API change by renaming timestamp and filter parameters.
- Renamed
sampled_attosample_timein metrics and states iteration and aggregation - Updated
PBTimeFiltercalls to usestart_time/end_timeinstead ofstart/end - Propagated field-name changes in both the iterator and aggregation client
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/frequenz/client/reporting/_types.py | Renamed sampled_at accesses to sample_time in iteration and in AggregatedMetric.sample |
| src/frequenz/client/reporting/_client.py | Updated two PBTimeFilter constructions to use start_time/end_time parameters |
Comments suppressed due to low confidence (1)
src/frequenz/client/reporting/_types.py:95
- Add or update unit tests to verify that the new
sample_timefield is correctly converted for all metric samples, ensuring backward compatibility of timestamp handling.
ts = sample.sample_time.ToDatetime().replace(tzinfo=timezone.utc)
flora-hofmann-frequenz
force-pushed
the
update_report_api
branch
from
5429a06 to
4ebf5f3
Compare
github-actions
bot
added
part:docs
flora-hofmann-frequenz
force-pushed
the
update_report_api
branch
from
4ebf5f3 to
3b4a6f0
Compare
cwasicki
previously approved these changes
Jul 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
flora-hofmann-frequenz
force-pushed
the
update_report_api
branch
from
3b4a6f0 to
785d79e
Compare
|
Sorry, I need a re-review on this. Only picked up the protobuf dependency when it failed the merge queue... |
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
update_report_api
branch
from
785d79e to
0668841
Compare
cwasicki
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.