Fix sampled_at for metrics #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the timestamp field used when iterating over metric and state samples, switching from sample_time to sampled_at.
- Use
sampled_atinstead ofsample_timefor metric samples - Use
sampled_atinstead ofsample_timefor state entries
Comments suppressed due to low confidence (2)
src/frequenz/client/reporting/_types.py:95
- Add a unit test to verify that
sampled_atis correctly converted to UTC datetime for metric samples.
ts = sample.sampled_at.ToDatetime().replace(tzinfo=timezone.utc)
src/frequenz/client/reporting/_types.py:130
- Add a unit test to verify that
sampled_atis correctly converted to UTC datetime for state entries.
ts = state.sampled_at.ToDatetime().replace(tzinfo=timezone.utc)
flora-hofmann-frequenz
force-pushed
the
fix_sample_error
branch
from
f355501 to
98b1e28
Compare
cwasicki
reviewed
Jul 10, 2025
RELEASE_NOTES.md
Outdated
| ## Bug Fixes | ||
|
|
||
| - Update example in README to use `receive_single_component_data`. | ||
| - Keep `sampled_at` for metric retrieval. |
There was a problem hiding this comment.
This doesn't need a release notes entry since it wouldn't change between two releases
flora-hofmann-frequenz
added
the
cmd:skip-release-notes
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
fix_sample_error
branch
from
98b1e28 to
901a278
Compare
cwasicki
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.