Skip to content

Conversation

@cwasicki
Copy link
Contributor

@cwasicki cwasicki commented Sep 13, 2024

States can now be requested via the client and are provided through the flat iterator. They can be identified via their category state, warning and error, respectively. Each individual state is provided as its own sample.

Support for states is also added to the CLI tool via the --states flag. As of now requests for states without any metrics are not yet supported by the service.

Fixes #25

@github-actions github-actions bot added the part:docs Affects the documentation label Sep 13, 2024
@cwasicki cwasicki force-pushed the states branch 2 times, most recently from 89b2ef5 to 7d486a1 Compare September 13, 2024 17:33
Copy link
Collaborator

@flora-hofmann-frequenz flora-hofmann-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think it makes sense to keep the states information in the client and not add it to the interface repo as it only exposes them.

@cwasicki cwasicki enabled auto-merge September 17, 2024 14:13
States can now be requested via the client and are provided through the
flat iterator. They can be identified via their category `state`,
`warning` and `error`, respectively. Each individual state is provided
as its own sample.

Support for states is also added to the CLI tool via the `--states`
flag. As of now requests for states without any metrics are not yet
supported by the service.

Signed-off-by: cwasicki <[email protected]>
Signed-off-by: cwasicki <[email protected]>
@cwasicki cwasicki added this pull request to the merge queue Sep 17, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 0c1cdb6 Sep 17, 2024
14 checks passed
@cwasicki cwasicki deleted the states branch September 17, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support request include option for states

2 participants