Initial version of the code #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
part:tests
llucax
added
the
cmd:skip-release-notes
|
I derailed a bit while importing the non-default constructible part 😬 There are still a couple more modules I want to include: |
llucax
commented
Jun 19, 2024
llucax
commented
Jun 19, 2024
|
@daniel-zullo-frequenz thanks to your comment I found some issues when subclassing, the custom error wasn't used. I updated the PR to use a more consistent default exception (before we used 3 different ones depending on when it was raised) and to fix the issue with subclassing, but looking up for the exception to raise in the base classes if not found in the current class. I will enable auto-merge. |
This commit adds a new module `frequenz.core.typing` with a decorator
`disable_init` that can be used to disable the `__init__` constructor of
a class. This is useful when a class doesn't provide a default
constructor and requires the use of a factory method to create
instances.
The code is loosely based on the `_NoDefaultConstructible` class in the
SDK [`frequenz.sdk.timeseries._quantities`][1], but it was completely
rewritten to be more generic and to use a decorator instead of
inheritance, which makes also much easier to use.
```python
@disable_init
class MyClass(Super):
pass
```
Versus:
```python
class MyClass(
Super,
metaclass=_NoDefaultConstructible,
):
pass
```
Also it is safer to use, as it will raise an error as soon as a class is
declared with an `__init__` method.
[1]: https://github.com/frequenz-floss/frequenz-sdk-python/blob/88bd28e2f21b930279d66c1daf3deeaf6f9bb07a/src/frequenz/sdk/timeseries/_quantities.py#L505-L522
Signed-off-by: Leandro Lucarella <[email protected]>
This module provides general purpose async tools that can be used to simplify the development of asyncio-based applications. The code and tests were imported from the SDK: * https://github.com/frequenz-floss/frequenz-sdk-python/blob/88bd28e2f21b930279d66c1daf3deeaf6f9bb07a/src/frequenz/sdk/actor/_background_service.py * https://github.com/frequenz-floss/frequenz-sdk-python/blob/88bd28e2f21b930279d66c1daf3deeaf6f9bb07a/src/frequenz/sdk/_internal/_asyncio.py We need to ignore type hints for async-solipsism because we start using it now and it doesn't provide type hints. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
|
Thanks, updated! |
daniel-zullo-frequenz
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__asynciomodule with general purpose async toolsdatetimemodule with aUNIX_EPOCHconstant