Move Interval to math
#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes the now empty collections module. Signed-off-by: Leandro Lucarella <[email protected]>
Now that we have 2 separate things to test in the math module, we use a sub-directory to store the tests. Signed-off-by: Leandro Lucarella <[email protected]>
Now that the tests for each part are in a separate file, we don't need to add prefixes to it, making the tests names shorter and less redundant in the logs. Signed-off-by: Leandro Lucarella <[email protected]>
Now that the module has been removed, we don't need to label it anymore. Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
part:tests
|
Not 100% convinced it belongs to |
llucax
added
cmd:skip-release-notes
In particular the `__str__` method returns a much more compact representation. Signed-off-by: Leandro Lucarella <[email protected]>
Marenz
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
Intervalis not really a collection, as it doesn't store any objects, it is more of a mathematical concept, so we move the class to themathmodule and remove thecollectionsmodule.