Skip to content

Support multiple target actors for one type of dispatch #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 18, 2025
Merged

Support multiple target actors for one type of dispatch #104

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
27252a8
ActorDispatcher: Support dispatches referring to different actors
Marenz Jan 28, 2025
df2f8a1
Remove unused async keyword from Dispatcher.start
Marenz Feb 10, 2025
5e7bfb9
Fix broken MergeByTypeTarge.identity function
Marenz Feb 4, 2025
e4fea21
Add `Dispatcher.manage` to manage dispatchable actors
Marenz Feb 4, 2025
df88828
Limit status update receiver queue to 1 and disable warning
Marenz Feb 10, 2025
2c29ab7
Rename: Use start/stop dispatching terminology
Marenz Feb 10, 2025
bd75c0f
ActorDispatcher: Rename map_dispatch to dispatch_identity
Marenz Feb 10, 2025
07a077e
ActorDispatcher: Make `None` default identity (id)
Marenz Feb 10, 2025
5ddb903
Update readme, make it ready for release
Marenz Feb 11, 2025
484c90b
Make the dispatcher instance awaitable
Marenz Feb 11, 2025
94b8efe
Catch & log exceptions on actor startup
Marenz Feb 11, 2025
f3b4146
Don't warn for changing dispatch parameters: It's a normal action
Marenz Feb 12, 2025
e0c5d8d
Turn `Dispatcher` into a background service
Marenz Feb 12, 2025
23cc65f
Wait for bg services as well in `Dispatcher.wait`
Marenz Feb 17, 2025
9747b15
Don't pass a name to Dispatcher background service
Marenz Feb 17, 2025
7d43537
Clear dispatches after waiting for them to stop
Marenz Feb 17, 2025
6c34157
Remove abstraction level `MergeByIdentity` and make it root instead
Marenz Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/frequenz/dispatch/_actor_dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ async def _start_actor(self, dispatch: Dispatch) -> None:
if self._updates_sender is not None:
sent_str = ", sent a dispatch update instead of creating a new actor"
await self._updates_sender.send(dispatch_update)
_logger.warning(
_logger.info(
Comment on lines -175 to +184
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get this change, the commit message says " Don't warn for changing dispatch parameters: It's a normal action ", does this mean that _start_actor is called every time a dispatch is updated? If so, I would even make this log a debug or remove it completely, because it seems misleading, as it was never the intention to start the actor if it was just a dispatch update.

If there is a way to tell if this is called because a dispatch just started or was updated, then maybe we can log more meaningful messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, there is a way, but it's not available to the actor_dispatcher (without restructuring).
The idea is that the dispatch instance tells us the desired state, no matter the previous state, so from that perspectives it doesn't matter whether it was an update or a new dispatch, both cases should do both, start or update a running actor instance..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this a debug then, because it is completely normal and probably not very useful to get that info when things are running. But not hung to block this PR on.

"Actor for dispatch type %r is already running%s",
dispatch.type,
sent_str,
Expand Down