Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Apr 1, 2025

  • Fix documentation phrasing
  • Add DispatchInfo._src for when requiring more context

Copilot AI review requested due to automatic review settings April 1, 2025 15:30
@Marenz Marenz requested a review from a team as a code owner April 1, 2025 15:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the source Dispatch for complex scenarios by adding a new _src field to DispatchInfo and updating the related actor dispatcher code.

  • Updated DispatchInfo documentation with the new _src field.
  • Modified the actor dispatcher to pass the dispatch as _src.
  • Updated release notes to document the new feature.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/frequenz/dispatch/_actor_dispatcher.py Adds _src to DispatchInfo and updates documentation in _start_actor.
RELEASE_NOTES.md Updates release notes to include the new _src feature.

@github-actions github-actions bot added part:docs Affects the documentation part:dispatcher Affects the high-level dispatcher interface labels Apr 1, 2025
@Marenz Marenz requested a review from llucax April 2, 2025 09:04
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary hack to unblock other work, but I think we need to find a better solution for the long term.

@Marenz Marenz added this pull request to the merge queue Apr 3, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 797b489 Apr 3, 2025
5 checks passed
@Marenz Marenz deleted the death-by-distraction branch April 3, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:dispatcher Affects the high-level dispatcher interface part:docs Affects the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants