Skip to content

Fetch dispatches in sync with periodic reconnect of client.stream #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 25, 2025
Merged

Fetch dispatches in sync with periodic reconnect of client.stream #155

merged 4 commits into from
Jun 25, 2025

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented May 21, 2025

Should probably use
frequenz-floss/frequenz-client-base-python#141
eventually to be less hacky?

@github-actions github-actions bot added part:docs Affects the documentation part:dispatcher Affects the high-level dispatcher interface labels May 21, 2025
llucax
llucax reviewed May 22, 2025
View reviewed changes
@Marenz Marenz force-pushed the periodic-event-check branch from ba62a7a to a79b3e3 Compare May 26, 2025 10:19
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label May 26, 2025
@Marenz Marenz changed the title Reconnect stream if there has been no event in 5 minutes Fetch dispatches in sync with periodic reconnect of client.stream May 26, 2025
@Marenz Marenz marked this pull request as ready for review May 26, 2025 10:21
@Marenz Marenz requested a review from a team as a code owner May 26, 2025 10:21
@Marenz Marenz added the status:blocked Other issues must be resolved before this can be worked on label May 26, 2025
@Marenz
Copy link
Contributor Author

Marenz commented May 26, 2025 •
edited
Loading

Blocked by frequenz-floss/frequenz-client-base-python#146

@Marenz Marenz requested a review from llucax May 26, 2025 16:47
@Marenz Marenz force-pushed the periodic-event-check branch from a79b3e3 to b5aff78 Compare May 27, 2025 16:32
ela-kotulska-frequenz
ela-kotulska-frequenz reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@ela-kotulska-frequenz ela-kotulska-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only needs rebasing :)

@Marenz
Copy link
Contributor Author

Marenz commented May 28, 2025

LGTM, only needs rebasing :)

Unfortunately, using a new base-client also means allowing a new base client version in microclient, so we will have to release both base-client and microclient

@llucax
Copy link
Contributor

llucax commented Jun 2, 2025

"microclient" 😆

llucax
llucax reviewed Jun 2, 2025
View reviewed changes
@Marenz Marenz force-pushed the periodic-event-check branch from b5aff78 to 59eb1b3 Compare June 2, 2025 12:36
@Marenz Marenz force-pushed the periodic-event-check branch from 59eb1b3 to bb61120 Compare June 12, 2025 18:50
@github-actions github-actions bot added the part:tests Affects the unit, integration and performance (benchmarks) tests label Jun 12, 2025
llucax
llucax reviewed Jun 13, 2025
View reviewed changes
@llucax llucax mentioned this pull request Jun 13, 2025
Closed
@Marenz Marenz marked this pull request as draft June 16, 2025 11:34
@Marenz Marenz marked this pull request as draft June 16, 2025 11:34
@Marenz Marenz force-pushed the periodic-event-check branch from bb61120 to 300abeb Compare June 17, 2025 09:50
@Marenz Marenz requested a review from llucax June 17, 2025 09:50
@Marenz Marenz force-pushed the periodic-event-check branch from 300abeb to 571373d Compare June 24, 2025 12:49
@Marenz Marenz marked this pull request as ready for review June 24, 2025 12:50
@Marenz
Refresh the dispatches after a stream restart.
4e2e7c3 
To ensure we didn't miss any.

Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz force-pushed the periodic-event-check branch from 571373d to fa4ab8e Compare June 24, 2025 16:03
@Marenz
Copy link
Contributor Author

Marenz commented Jun 24, 2025

This is now ready

@Marenz Marenz removed the status:blocked Other issues must be resolved before this can be worked on label Jun 25, 2025
@Marenz Marenz added this pull request to the merge queue Jun 25, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit c7ee3cc Jun 25, 2025
6 checks passed
@Marenz Marenz deleted the periodic-event-check branch June 25, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ela-kotulska-frequenz ela-kotulska-frequenz ela-kotulska-frequenz left review comments

@llucax llucax llucax approved these changes

Assignees

No one assigned

Labels

part:dispatcher Affects the high-level dispatcher interface part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Marenz @llucax @ela-kotulska-frequenz