Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Jun 25, 2025

No description provided.

Signed-off-by: Mathias L. Baumann <[email protected]>
Copilot AI review requested due to automatic review settings June 25, 2025 13:50
@Marenz Marenz requested a review from a team as a code owner June 25, 2025 13:50
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:dispatcher Affects the high-level dispatcher interface labels Jun 25, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the obsolete local TargetComponents alias and conversion helper from the actor dispatcher, switches to using the upstream TargetComponents type, updates tests accordingly, and cleans up exports and release notes.

  • Drop _convert_target_components and local TargetComponents in _actor_dispatcher.py
  • Update tests to assert on the new TargetComponents directly
  • Remove TargetComponents export in __init__.py and document removal in release notes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/test_managing_actor.py Updated assertions to use the new target type and removed old import
src/frequenz/dispatch/_actor_dispatcher.py Removed conversion helper and alias; import upstream TargetComponents
src/frequenz/dispatch/init.py Removed legacy TargetComponents from public API exports
RELEASE_NOTES.md Documented removal of TargetComponents (with typos)
Comments suppressed due to low confidence (2)

tests/test_managing_actor.py:180

  • The test references an undefined symbol TargetIds. Did you mean to import TargetComponents or use the correct upstream type? Update the import or assertion to use the proper TargetComponents alias.
    assert event.components == TargetIds(

RELEASE_NOTES.md:9

  • There are typos here: disptach should be dispatch and tye should be type.
The `frequenz.disptach.TargetComponents` tye was removed, use `frequenz.client.dispatch.TargetComponents` instead.

@Marenz Marenz enabled auto-merge June 25, 2025 13:51
@Marenz Marenz requested review from ela-kotulska-frequenz and shsms and removed request for stefan-brus-frequenz June 25, 2025 13:52
@Marenz Marenz disabled auto-merge June 25, 2025 14:00
@Marenz Marenz merged commit a7e380b into frequenz-floss:v0.x.x Jun 25, 2025
5 checks passed
@Marenz Marenz deleted the remove_obsolete_type branch June 25, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:dispatcher Affects the high-level dispatcher interface part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants