Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Sep 29, 2025

@Marenz Marenz requested a review from a team as a code owner September 29, 2025 17:13
@Marenz Marenz requested review from Copilot and llucax September 29, 2025 17:13
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:dispatcher Affects the high-level dispatcher interface labels Sep 29, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the dispatch fetching functionality by filtering out completed dispatches, fetching only ongoing ones to improve performance and relevance.

  • Adds an end_from parameter to the dispatch client API call to filter out past dispatches
  • Updates tests to handle the new behavior where finished dispatches are filtered out
  • Temporarily uses a development version of the frequenz-client-dispatch dependency

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
src/frequenz/dispatch/_bg_service.py Adds time-based filtering to only fetch ongoing dispatches using end_from parameter
tests/test_frequenz_dispatch.py Updates test expectations and adds logging to handle the new filtering behavior
pyproject.toml Temporarily switches to development branch of frequenz-client-dispatch dependency
RELEASE_NOTES.md Documents the new optimization feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Marenz Marenz force-pushed the fromage branch 2 times, most recently from 03a8d6a to ea7fe7d Compare September 29, 2025 17:21
@Marenz Marenz requested a review from Copilot September 29, 2025 17:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, no approving only because of the PR dependency.

@Marenz Marenz added this pull request to the merge queue Sep 30, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit cb74e80 Sep 30, 2025
5 checks passed
@Marenz Marenz deleted the fromage branch September 30, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:dispatcher Affects the high-level dispatcher interface part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants