Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Oct 27, 2025

Summary

  • Update documentation to use new auth_key and sign_secret parameters instead of deprecated key parameter
  • Update environment variable names from DISPATCH_API_KEY to DISPATCH_API_AUTH_KEY and add DISPATCH_API_SIGN_SECRET
  • Update dispatch client version constraint from < 0.12.0 to < 1.0.0 to prepare for v1 release

Copilot AI review requested due to automatic review settings October 27, 2025 10:45
@Marenz Marenz requested a review from a team as a code owner October 27, 2025 10:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dispatch client integration to prepare for the v1 release by migrating from deprecated authentication parameters to the new authentication model and updating version constraints.

Key Changes:

  • Migrated authentication parameters from key to auth_key and sign_secret in all documentation examples
  • Updated environment variable names from DISPATCH_API_KEY to DISPATCH_API_AUTH_KEY and added DISPATCH_API_SIGN_SECRET
  • Relaxed version constraint for frequenz-client-dispatch from < 0.12.0 to < 1.0.0

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/frequenz/dispatch/_actor_dispatcher.py Updated example code to use new auth_key and sign_secret parameters with corresponding environment variables
pyproject.toml Updated frequenz-client-dispatch dependency version constraint to allow versions up to 1.0.0
README.md Updated example code to use new auth_key and sign_secret parameters with corresponding environment variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:dispatcher Affects the high-level dispatcher interface labels Oct 27, 2025
@Marenz Marenz requested a review from llucax October 27, 2025 10:46
- Replace deprecated 'key' parameter with 'auth_key' in examples
- Add 'sign_secret' parameter to examples
- Update environment variable names from DISPATCH_API_KEY to DISPATCH_API_AUTH_KEY
- Add DISPATCH_API_SIGN_SECRET environment variable

Signed-off-by: Mathias L. Baumann <[email protected]>
- Change frequenz-client-dispatch version from < 0.12.0 to < 1.0.0

Signed-off-by: Mathias L. Baumann <[email protected]>
- Mark authentication parameter changes as breaking
- Update environment variable changes as breaking
- Add summary for v1 preparation

Signed-off-by: Mathias L. Baumann <[email protected]>
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

Comment on lines -9 to -10
* The `key` parameter in the `Dispatcher` constructor is now deprecated. Use `auth_key` instead. The `sign_secret` parameter is an additional optional parameter for signing.
* The `components` property in `DispatchInfo` is now deprecated. Use `target` instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these were old release notes from the previous release, right? So the previous release deprecated them and this release will remove the deprecated names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are still only deprecated , nothing is made incompatible yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:dispatcher Affects the high-level dispatcher interface part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants