-
Couldn't load subscription status.
- Fork 6
Prepare for v1: Update auth parameters and client version #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.x.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the dispatch client integration to prepare for the v1 release by migrating from deprecated authentication parameters to the new authentication model and updating version constraints.
Key Changes:
- Migrated authentication parameters from
keytoauth_keyandsign_secretin all documentation examples - Updated environment variable names from
DISPATCH_API_KEYtoDISPATCH_API_AUTH_KEYand addedDISPATCH_API_SIGN_SECRET - Relaxed version constraint for
frequenz-client-dispatchfrom< 0.12.0to< 1.0.0
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/dispatch/_actor_dispatcher.py | Updated example code to use new auth_key and sign_secret parameters with corresponding environment variables |
| pyproject.toml | Updated frequenz-client-dispatch dependency version constraint to allow versions up to 1.0.0 |
| README.md | Updated example code to use new auth_key and sign_secret parameters with corresponding environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Replace deprecated 'key' parameter with 'auth_key' in examples - Add 'sign_secret' parameter to examples - Update environment variable names from DISPATCH_API_KEY to DISPATCH_API_AUTH_KEY - Add DISPATCH_API_SIGN_SECRET environment variable Signed-off-by: Mathias L. Baumann <[email protected]>
- Change frequenz-client-dispatch version from < 0.12.0 to < 1.0.0 Signed-off-by: Mathias L. Baumann <[email protected]>
- Mark authentication parameter changes as breaking - Update environment variable changes as breaking - Add summary for v1 preparation Signed-off-by: Mathias L. Baumann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question.
| * The `key` parameter in the `Dispatcher` constructor is now deprecated. Use `auth_key` instead. The `sign_secret` parameter is an additional optional parameter for signing. | ||
| * The `components` property in `DispatchInfo` is now deprecated. Use `target` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these were old release notes from the previous release, right? So the previous release deprecated them and this release will remove the deprecated names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are still only deprecated , nothing is made incompatible yet
Summary
auth_keyandsign_secretparameters instead of deprecatedkeyparameterDISPATCH_API_KEYtoDISPATCH_API_AUTH_KEYand addDISPATCH_API_SIGN_SECRET