Send stop signal when duration is reached #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marenz
commented
Sep 11, 2024
Marenz
commented
- Reset release notes
- Send STOPPED message when duration is reached
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
github-actions
bot
added
part:docs
llucax
reviewed
Sep 11, 2024
| _logger.info( | ||
| "Dispatch %s running for %s", dispatch.id, dispatch.duration | ||
| ) | ||
| await asyncio.sleep(dispatch.duration.total_seconds()) |
There was a problem hiding this comment.
Are you sure a sleep will work? Doesn't this block receiving/running any other dispatch while the current dispatch is running? Shouldn't you use timers instead or this code runs on a separate task for every dispatch that is currently running?
There was a problem hiding this comment.
Yes ,currently we have one task for each dispatch running.
llucax
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.