Skip to content

Hack-Fix bug that eventloop leaks into other tests #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Hack-Fix bug that eventloop leaks into other tests #62

wants to merge 1 commit into from

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Sep 30, 2024 •
edited
Loading

This is so far the only reliable way to make the bug not happen.

@Marenz Marenz requested a review from a team as a code owner September 30, 2024 14:49
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:dispatcher Affects the high-level dispatcher interface labels Sep 30, 2024
@Marenz
Hack-Fix bug that eventloop leaks into other tests
bd88c0c 
This is so far the only reliable way to make the bug not happen.

Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz enabled auto-merge October 1, 2024 09:29
llucax
llucax reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a solution as replacing the event_loop fixture is deprecated IIRC, but it might be a way to dig more about why this is fixing the issue, so why we have the issue in the first place.

@Marenz
Copy link
Contributor Author

Marenz commented Oct 3, 2024

Unfortunately it also happens with this

@Marenz Marenz closed this Oct 17, 2024
auto-merge was automatically disabled October 17, 2024 15:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llucax llucax llucax left review comments

@hannah-stevenson-frequenz hannah-stevenson-frequenz Awaiting requested review from hannah-stevenson-frequenz hannah-stevenson-frequenz is a code owner automatically assigned from frequenz-floss/api-dispatch-team

Assignees

No one assigned

Labels

part:dispatcher Affects the high-level dispatcher interface part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marenz @llucax