Skip to content

Fix recurrence #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix recurrence #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

## Summary

* `frequenz-sdk` dependency has been extended to include version `1.0.0-rc1000`.
This is a hot fix for recurrence not working
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe better what the issue exactly was here too? As a user I have no idea how my code was affected before this release and what should I expect from this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is really only one user and I talked to him already ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can assume that it wasn't working at all before, the chance that it was is very low.
If it was working for the user before, they must already have a detailed understanding of this problem or they couldn't have worked around it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you don't know for sure, this is a public repo. I'm sure we have plenty of external users :trollface:

But anyway, I think it is good practice to write notes that are useful, otherwise there isn't much point in writing them at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I see all the logs and request in the API, I know for sure :P

But.. yes, I suppose it is good practice.

11 changes: 6 additions & 5 deletions src/frequenz/dispatch/_dispatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,14 @@ def _prepare_rrule(self) -> rrule.rrule:
dtstart=self.start_time,
count=count,
until=until,
byminute=self.recurrence.byminutes,
byhour=self.recurrence.byhours,
byminute=self.recurrence.byminutes or None,
byhour=self.recurrence.byhours or None,
byweekday=[
_RRULE_WEEKDAY_MAP[weekday] for weekday in self.recurrence.byweekdays
],
bymonthday=self.recurrence.bymonthdays,
bymonth=self.recurrence.bymonths,
]
or None,
bymonthday=self.recurrence.bymonthdays or None,
bymonth=self.recurrence.bymonths or None,
interval=self.recurrence.interval,
)

Expand Down
Loading