Remove methods that were moved to client repo #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Marenz
force-pushed
the
remclean
branch
2 times, most recently
from
2d28695 to
6782f52
Compare
github-actions
bot
added
the
part:tooling
* The `running` property was renamed to `started` * The running state was removed Signed-off-by: Mathias L. Baumann <[email protected]>
The modules were moved to client-dispatch Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
This makes the code cleaner. Signed-off-by: Mathias L. Baumann <[email protected]>
llucax
previously approved these changes
Dec 4, 2024
I missed it already, tbh. Now you have to make double-sure you check for the .type before looking at Still not convinced this is a better interface that leads to less errors. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Maybe the receiver should come pre-filtered for a set of types you specify 🤔 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR looks large, but most commits are just small changes. Tried to keep it well separated.