Redesign managing actor #95
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can always send a status update to a new receiver Signed-off-by: Mathias L. Baumann <[email protected]>
github-actions
bot
added
the
part:dispatcher
llucax
reviewed
Jan 8, 2025
| dispatch_type: str, | ||
| running_status_receiver: Receiver[Dispatch], | ||
| updates_sender: Sender[DispatchUpdate] | None = None, | ||
| actor: Actor | Set[Actor] | None = None, |
There was a problem hiding this comment.
I was going for an actor factory. Will submit my WIP as a draft PR so maybe you can get some inspiration about it, or we can discuss pros and cons from the different approaches.
Comment on lines
+138
to
+144
| def new_receiver(self) -> Receiver[DispatchUpdate]: | ||
| """Create a new receiver for dispatch updates. | ||
| Returns: | ||
| A new receiver for dispatch updates. | ||
| """ | ||
| return self._updates_channel.new_receiver() |
There was a problem hiding this comment.
Oh, yes! I also thought about this, but I didn't start to address this but was my next step. I think this actor should also stop being an actor and just be a background service.
I'm not sure it is needed with my approach, but I think it would be convenient anyway, I see no advantages in delegating the creation of the channel to the outside.
|
replaced by #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can always send a status update to a new receiver