-
Notifications
You must be signed in to change notification settings - Fork 8
Update Alert Notebook #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alert Notebook #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
|
please also double check the German translation |
|
There is still quite a lot of code in the notebook, which would be better moved to the lib. Also we should aim for having only a single library (notebooks) that the users need to worry about, not 3. |
Translation LGTM |
There is some code that will be deleted once this PR is merged frequenz-floss/frequenz-reporting-python#58 I will review other parts of the notebook to see what can be moved to the library. Do you see specific parts that should be moved already?
You are right. Just realised that |
|
From my side it's fine to do this later. We should aim for notebooks that have just couple of lines for interaction with the user and display, and everything else in a python module. |
428cccd to
7d87593
Compare
- Update the introduction in the instructions. - Utilise the updated `MicrogridConfig` class to simplify the toml file loading. - Utilise the new `state_analysis` module for detecting and analysing component state transitions and alerts from reporting data. This simplifies the notebook by removing a now obsolete code. Signed-off-by: cyiallou - Costas <[email protected]> s
7d87593 to
e68922d
Compare
|
Updated @cwasicki |
MicrogridConfigclass to simplify the tomlfile loading.
state_analysismodule for detecting and analysingcomponent state transitions and alerts from reporting data. This
simplifies the notebook by removing a now obsolete code.