Config parameters for the component graph #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Based on #2 |
A `ComponentGraphConfig` object now needs to be passed when constructing a `ComponentGraph` instance. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
This would make it easy to test upcoming graph config parameters. Signed-off-by: Sahas Subramanian <[email protected]>
This means users don't have to fix one issue at a time and recreate the graph to get the next error, but can instead get all the issues in the graph at once. Signed-off-by: Sahas Subramanian <[email protected]>
When true, inverters with `InverterType::Unspecified` are treated as having `InverterType::Battery`. This commit also adds "tracing" as a dependency and logs warnings when inverters with unspecified type are encountered. Signed-off-by: Sahas Subramanian <[email protected]>
When `true`, the graph will be considered valid even if it has unconnected components that are not reachable from the root. Signed-off-by: Sahas Subramanian <[email protected]>
When `true`, the graph will be considered valid even if validation failed for some of the components. Signed-off-by: Sahas Subramanian <[email protected]>
When this is `true`, formulas will be generated without considering fallback components. Signed-off-by: Sahas Subramanian <[email protected]>
Collaborator
Author
|
Rebased on latest. |
shsms
added
the
cmd:skip-release-notes
Collaborator
Author
|
Will add release notes when we are ready to make the first release. |
matthias-wende-frequenz
approved these changes
Jan 14, 2025
Merged
via the queue into
frequenz-floss:v0.x.x
with commit Jan 14, 2025
4c4ee64
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring the validation requirements of the component graph.