Add check-release-notes CI job #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
cwasicki
previously approved these changes
Jan 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
Also add a release notes file and a template release notes file.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
llucax
reviewed
Jan 13, 2025
.github/workflows/ci.yaml
Outdated
| on: | ||
| merge_group: | ||
| push: | ||
| branches: [ v0.x.x ] |
There was a problem hiding this comment.
While you are at it, it might be also worth adding:
branches-ignore:
# Ignore pushes to merge queues.
# We only want to test the merge commit (`merge_group` event), the hashes
# in the push were already tested by the PR checks
- 'gh-readonly-queue/**'
- 'dependabot/**'Also not sure why only testing v0.x.x.
llucax
previously approved these changes
Jan 13, 2025
Signed-off-by: Sahas Subramanian <[email protected]>
shsms
force-pushed
the
release-notes-check
branch
from
b95d5b5 to
298b460
Compare
llucax
previously approved these changes
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Signed-off-by: Sahas Subramanian <[email protected]>
llucax
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a release notes file and a template release notes file.