Add a formula generator to coalesce metrics from multiple components #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added
the
cmd:skip-release-notes
niklas-timpe
approved these changes
Jun 24, 2025
Collaborator
niklas-timpe
left a comment
niklas-timpe
left a comment
There was a problem hiding this comment.
lgtm.
Just out of curiosity, why do we use a BTree as argument for IDs and not just an array?
Collaborator
Author
With this, we don't have to check for duplicates. Also, I think the graph implementation gives us component IDs as sets, so we can take those and pass them directly to the formula generators. |
Merged
via the queue into
frequenz-floss:v0.x.x
with commit Jun 24, 2025
1ed2a5b
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.